Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ovarious to latest #4323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ovarious to latest #4323

wants to merge 1 commit into from

Conversation

mcm1957
Copy link
Collaborator

@mcm1957 mcm1957 commented Nov 27, 2024

@oweitman
replacement for #4321

@github-actions github-actions bot added the auto-checked This PR was automatically checked for obvious criterias label Nov 27, 2024
@mcm1957 mcm1957 mentioned this pull request Nov 27, 2024
@mcm1957 mcm1957 added RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. new at LATEST labels Nov 27, 2024
Copy link

Automated adapter checker

ioBroker.ovarious

Downloads Number of Installations (latest) - Test and Release
NPM

👍 No errors found

  • 👀 [W401] Cannot find "ovarious" in latest repository
  • 👀 [W951] .npmignore found but "files" is used at package.json. Please remove .npmignore.

Add comment "RE-CHECK!" to start check anew

Copy link

ioBroker repository information about New at LATEST tagging

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them. And please check the following information if not yet done:

You will find the results of the review and eventually issues / suggestions as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask.
mcm1957

@simatec Please take a look in respect to responsive design. Thanks

@mcm1957
Copy link
Collaborator Author

mcm1957 commented Nov 27, 2024

@oweitman

Just a pre-preview

This adapter seems to provide a vis (vis 1) widget. So it it should be named vis-ovarious. (Already checked with @Apollon77 and @GermanBluefox). Please rename adapter.

In addition please remove unused code / modules like main.js or admin UI which does not configure anything.

If you have any questions pleas feel free to ask and/or contact @Apollon77 / @GermanBluefox .

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. and removed RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. labels Nov 27, 2024
@oweitman
Copy link
Contributor

oweitman commented Nov 27, 2024

This adapter seems to provide a vis (vis 1) widget. So it it should be named vis-ovarious. (Already checked with @Apollon77 and @GermanBluefox). Please rename adapter.
Der Adapter nennt sich ja (o)various und ist geplant das er diverse Funktionalitäten enthalten wird, die nicht jeweils in einen eigenen Adapter passen bzw, sich lohnen. Daher auch nicht vis-, da der Adapter wahrscheinlich auch nicht nur vis-relevante Funktionen enthalten wird.
Die anderen Dateien, sind ebenfalls als Platzhalter vorgesehen (Konfiguration, main).
Das der adapter aktuell nicht gestartet wird, ist durch die mode entsprechend vorgesehen.

@github-actions github-actions bot added the *📬 a new comment has been added label Nov 27, 2024
@mcm1957 mcm1957 added the REVIEW needed (apollon77) A developer from the ioBroker Team will review the adapter, will provide comments or require changes label Nov 28, 2024
@Apollon77
Copy link
Collaborator

@oweitman Hm ... Wie sollen User denn Verstehen was der Adapter kann und wozu er da ist? Die Standard Filterung von usern erfolgt über den namen soweit wir wissen. Das bedeutet das "Sammelsorium Adapter" (So übersetze ich den Namen jetzt mal frech) allgemein nicht so sonderlich Zielführend sind projektseitig versuchen wir solche eigentlich zu vermeiden weil Sie, wie Didie Erfahrung der vergangeheot zeigt, mehr Verwirrung und Unklarheiten stiften als Nutzen.

Weiterhin ist in deinerm Satz alles sehr "vielleicht" undd amit kann der Adapter vielleicht so bleiben oder vielleicht zum "Monster" werden weil alles und nichts rein kommt.

Aus Projektsicht ist es besser mehrere kleine Adapter zu haben die dann aber speziffische (oder nahe zusammenliegende(´) Funktionen haben als eine "Eierlegende Wollmilchsau" (nenne es so weil genau solche Diskussionen in der Vergangenheit alle schonmal da waren).

Bitte überdenke nochmal Dein Konzept auch aus Usersicht. Danke

Für peinen persönlichen Austausch dazu bin ich über Forum oder Telegram oder Discord jederzeit erreichbar.

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review new at LATEST ON HOLD PR is set ON HOLD due to pending question or major issues. REVIEW needed (apollon77) A developer from the ioBroker Team will review the adapter, will provide comments or require changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants