reminder 12.1.2025

To verify the Object structure of this adapter during REVIEW please export the object structure of a working installation and attach the file i. You find a guide how to export the object struture here: https://github.com/ioBroker/ioBroker.repochecker/blob/master/OBJECTDUMP.md

Thanks

tagesschau.0.json

Automated adapter checker

ioBroker.tagesschau

-

👍 No errors found

• 👀 [W401] Cannot find "tagesschau" in latest repository

Add comment "RE-CHECK!" to start check anew

@ticaki

First of all - THANK YOU for the time and effort you spend to maintain this adapter.

I would like to give some feedback based on my personal oppinion. @Apollon77 might have additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him if you cannot follow my suggestions or want to discuss some special aspects.

• Readme.md must be written in pure english

  As ioBroker is an international software supporting several languages the main Readme.md file should be written in english. Its ok to add additional Readme-.mds of course.

• language used for stateIds and names

  All stateIds must be named using english wording unless the data is directly received from an external source. (Thats ok)
  All names must use either english wording or use i18n multilanguage setup.

  So please change the german names to either english or use i18n objects containing at least english and german translations. You can generate such blocks i.e. by using https://translator-ui.iobroker.in/

• function sleep is redundant

  Implementing a private sleep function is redundant as iobroker provide suppoerst delay with same functionallity including the integrated cleanup at onUnload. See https://github.com/ioBroker/ioBroker.js-controller/blob/99469b9944509b9c64b9a28da6d8dabf17a8ea74/packages/adapter/src/lib/adapter/adapter.ts#L2712
  But consider this as a suggestion ist definitly not blocking.

• object ids and name attribute of objects

  Object Ids must be named in english.

  The "name" attribute of all objects / states must be either a string in english or an i18n multilingual object with all supported languages. The only exception would be if the name attribute is directly delivered by the external system - which isn't he case here. I would suggest to use i18n

• Object hirarchy

  Object hirarchy must be device -> channel -> state. device and / or channel might be omitted. Channel must be below device and there must be a maximum of one device and one channel within one leaf. So i.e. device -> channel -> channel is invalid. Folders can be placed anywhere in structure. States must not have any children

  Please adjust structure / types.

• reevaluate state roles

  Only the values specified here (https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md) may be used as state roles. Do not invent new names as this might disturb the functionalyity of other adapters or vis.

  In addition the roles MUST match the read/write functionality. As an example a role value.* requires that the state is a readable state. Input states (write only) should have roles like level.*. Please read the description carefully. States with role 'button' should (must) have attribute 'common.read=false' set. A button ( "Taster" in german only triggers when you press but else has no state), so it should also be not readable. This is also like HomeMatic does it. A switch has clear states true or false and so can be read.

  firstNewsAt is writeable. Su role 'value' is invalid. Should be 'level' I suggest.

• some labels seem to have no translation into all languages

  All text with admin UI (labels, tooltips, etc. must be at least provided in english (as default) and german language. Using i18n evironment is highy recommended. Using direct i18n objects is possible but discouraged as this block maintainace using weblate. i18n objects must provide all supported langiugages.

• Is there any reason to not use i18n translation environment?

  I suggest to evaluate to use i18n translation environment and the iobroker/adapter-dev environment (https://github.com/ioBroker/adapter-dev#iobroker-adapter-dev). You could easyly add new strings to the english json and run npm run translate afterward. When using i18n environment activating iobrokers weblate translation system (see https://github.com/ioBrokerTranslator/doc) is trivial.

Thanks for reading and evaluating this suggestions.
McM1957

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

reminder 31.1.2025

As I write in the header - this adapter only provides information in German. That is the reason why I have not provided a translation.

If it is therefore not welcome in the latest, I will change that. Just wanted to save myself some work.

Everything else will be taken care of.

States must not have any children

I can't find the state that has children

Oh, that's probably just a standard text, I'm too tired.

As I write in the header - this adapter only provides information in German. That is the reason why I have not provided a translation.

Please provide english as standard and of course german as (one or eventually only) translations. There are other adapters which target german data only too and all provide english default text. AndI (and possibley you) will not deal with a french or russian oly adapter only because the adapetr target fren or russion data sources.

Of course you do not need to translate i.e. geografical names although possible its ok to list i.e. Bayern.

Thanks for your understanding.

States must not have any children

I can't find the state that has children

Oh, that's probably just a standard text, I'm too tired.

It's ok. You do not have states below states. I could have removed this sentacne from template. I'll not and do for further reviews to avoid confusion. Sorry for this.

All StateIds that are specified by the data source are as they are. All the ones I have created are in English.

The top data points 'wissen' etc are exactly what must be used in the url to get the data. I don't think it makes sense to alienate Ids from the data reference.

https://www.tagesschau.de/api2u/news/?regions=1,2,3&ressort=wissen

EDIT: Oh and forgot. The common.names of the folders below news are replaced by the value in title at runtime. Otherwise the default has 20 folders with the id 00-19 and the name News. I thought this was a helpful idea for users.

Everything else is done. Identifiers(admin, common.name) are all in i18n. German and English are controlled, rest auto-translated.

tagesschau.0.json