Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box can move in situation where it shouldn't move #71

Open
danieldeankon opened this issue Aug 2, 2020 · 2 comments · May be fixed by #81
Open

Box can move in situation where it shouldn't move #71

danieldeankon opened this issue Aug 2, 2020 · 2 comments · May be fixed by #81

Comments

@danieldeankon
Copy link

danieldeankon commented Aug 2, 2020

Steps to reproduce:

    N N W W W W W W
    W W W . . . . W
    W . P W B . . W
    W . . . . . . W 
    W . . . . . . W
    W . . . . . . W
    W . . S . . . W
    W . . . . . . W
    W W W W W W W W

I was able to stop the behaviour by changing the match expression on line 173 to

                            match immov.get(&pos) {
                                Some(id) => {
                                    to_move.clear();
                                    break
                                },
                                None => break,
                            }

I haven't tested rigorously to see whether or not this introduces any new unwanted behaviour, but it seems to not do so.

@L-F-Stack-Exchange
Copy link

Since the attached video seems corrupt, here's the result:

image

where the box is moved even though it is obstructed by a wall.

@desttinghim
Copy link

desttinghim commented Aug 8, 2020

This fix also prevents multiple of the same sounds playing at the same time when audio is introduced. When this happens it appears that the sounds suddenly got louder, but that's just what happens when the same sound is played simultaneously.

@iolivia iolivia linked a pull request Aug 15, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants