Use anchors instead of line numbers for 1.1-1.3 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iolivia
reviewed
Aug 17, 2020
| @@ -68,7 +68,7 @@ more dependencies. If this step fails and you see errors related to `alsa` and ` | |||
| Now let's actually use ggez in the main file and set up our window. This is just the simplest example of a ggez program that will give us a window with nothing else. Copy and paste this into the `main.rs` file and run again. | |||
|
|
|||
| ```rust | |||
| {{#include ../../../code/rust-sokoban-c01-01/src/main.rs}} | |||
| {{#include ../code/rust-sokoban-c01-01/src/main.rs:all}} | |||
There was a problem hiding this comment.
I think you might need to find/replace ../code -> ../../../code, this is because of the previous PR which moved files around in subdirectories 😄
|
hey @desttinghim, thanks a lot for this change! I think this is too big of a change to make after the book has already been written and lots of risk to mess up the code line numbers, will require a similar PR for all subsequent chapters, so I think I will close this for now. I might bring this back one day if I have more time to work on the book, thanks again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses anchors instead of line numbers for chapters 1.1 through 1.3. Cherry picked from my larger PR #75. First part in resolving #46