Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): hide from screen readers while animating #30035

Closed
wants to merge 7 commits into from
Closed

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Nov 22, 2024

Issue number: internal


What is the current behavior?

When the menu is presented on an Android device, TalkBack's focus rings may appear in the wrong position due to the transition (specifically transform styles). This occurs because the focus rings are initially displayed at the starting position of the elements before the transition begins.

What is the new behavior?

  • When an overlay is being animated (presenting or dismissing), the overlay will hide from screen readers. This allows Talkback to display the focus rings on the correct position.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.4.1-dev.11732305980.19d90e1c

Related to #29951

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 7:34pm

@github-actions github-actions bot added the package: core @ionic/core package label Nov 22, 2024
@thetaPC thetaPC marked this pull request as ready for review November 22, 2024 23:50
@thetaPC thetaPC requested a review from a team as a code owner November 22, 2024 23:50
@thetaPC thetaPC requested review from OS-pedrolourenco and brandyscarney and removed request for OS-pedrolourenco November 22, 2024 23:50
@thetaPC thetaPC marked this pull request as draft November 22, 2024 23:54
@thetaPC thetaPC removed the request for review from brandyscarney November 22, 2024 23:54
@thetaPC thetaPC closed this Nov 22, 2024
@thetaPC thetaPC deleted the ROU-11380 branch November 22, 2024 23:54
@thetaPC
Copy link
Contributor Author

thetaPC commented Nov 22, 2024

Closed since the branch name is wrong. Opened the correct one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant