Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared logic between XE and XR scripts where possible #25

Open
glennmatthews opened this issue Nov 28, 2016 · 1 comment
Open

Shared logic between XE and XR scripts where possible #25

glennmatthews opened this issue Nov 28, 2016 · 1 comment
Labels
enhancement

Comments

@glennmatthews
Copy link
Collaborator

Currently the iosxr_iso2vbox.py and iosxe_iso2vbox.py scripts have a lot of duplicate code. So that each script can benefit from bugfixes and enhancements to the other, we should create a shared library for any code that can reasonably be shared between the two scripts.
@xiaopeng163
Copy link

agree, also for #23, it's better if this tool can be provided as a python package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glennmatthews @xiaopeng163