Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Travis CI build should be organized. #65

Open
peter279k opened this issue Aug 25, 2018 · 2 comments
Open

The Travis CI build should be organized. #65

peter279k opened this issue Aug 25, 2018 · 2 comments
Assignees

Comments

@peter279k
Copy link
Contributor

peter279k commented Aug 25, 2018

πŸ‘¨β€πŸŽ¨
According to the Travis CI build log from my forked repository. I found some existed problems.

  • It's not really necessary to do the static analysis with phpstan in Travis CI build at this time.
    It should be removed. We have the unit tests and this is the optional enhancement work.
  • I think it's okay to use the php-cs-fixer to check the coding style.
  • I think the unit test looks like it's too slow. Perhaps it has some HTTP requests tests to cause this issue.
    IMHO, it should set the optional argument timeout for HTTP requests in php-http client so that it can let the execution time of unit test faster πŸ‘.

BTW, we can integrate the Travis CI service so that we can check where the problem is via unit test work πŸ˜„.

@Techworker
Copy link
Member

The tests don't execute HTTP requests, the tests work with some fixtures that take a lot of time to load - at least that is what I recognized the last time (I think this class was the problem). And the Kerl Tests are really resource intensive, thats why I restricted them to 1000, I think 100 would be better or we implement different test modes (full / partial).

@peter279k
Copy link
Contributor Author

peter279k commented Aug 25, 2018

@Techworker, thank you for your reply. I think it's not the HTTP requests after checking the test code again.

The IOTA\Tests\DummyData class is too slow? Let me deeply test that class...

@peter279k peter279k self-assigned this Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants