You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
π¨βπ¨
According to the Travis CI build log from my forked repository. I found some existed problems.
It's not really necessary to do the static analysis with phpstan in Travis CI build at this time.
It should be removed. We have the unit tests and this is the optional enhancement work.
I think it's okay to use the php-cs-fixer to check the coding style.
I think the unit test looks like it's too slow. Perhaps it has some HTTP requests tests to cause this issue.
IMHO, it should set the optional argument timeout for HTTP requests in php-http client so that it can let the execution time of unit test faster π.
BTW, we can integrate the Travis CI service so that we can check where the problem is via unit test work π.
The text was updated successfully, but these errors were encountered:
The tests don't execute HTTP requests, the tests work with some fixtures that take a lot of time to load - at least that is what I recognized the last time (I think this class was the problem). And the Kerl Tests are really resource intensive, thats why I restricted them to 1000, I think 100 would be better or we implement different test modes (full / partial).
π¨βπ¨
According to the Travis CI build log from my forked repository. I found some existed problems.
phpstan
in Travis CI build at this time.It should be removed. We have the unit tests and this is the optional enhancement work.
php-cs-fixer
to check the coding style.IMHO, it should set the optional argument
timeout
for HTTP requests inphp-http
client so that it can let the execution time of unit test faster π.BTW, we can integrate the Travis CI service so that we can check where the problem is via unit test work π.
The text was updated successfully, but these errors were encountered: