Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move min/max committable age checks and input commitment check from filter to syntactical block validation #242

Closed
2 tasks
jonastheis opened this issue Aug 2, 2023 · 0 comments · Fixed by #274 or iotaledger/iota.go#475
Assignees

Comments

@jonastheis
Copy link
Contributor

jonastheis commented Aug 2, 2023

  • make sure that the checks actually test the correct thing: a minCommittableAge=1 means that we can commit to a slot 10 once the first block in 12 has been accepted. This needs to be taken into account as such.
  • verify that commitments are correctly set according to the syntactical validation rules in the BlockIssuer's getCommitment function
@jonastheis jonastheis converted this from a draft issue Aug 2, 2023
@piotrm50 piotrm50 self-assigned this Aug 4, 2023
@piotrm50 piotrm50 moved this from Must Haves to In Progress in iota-core Aug 4, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in iota-core Aug 11, 2023
@jonastheis jonastheis added this to the 1.0 milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants