This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Resolve all inputs in Mempool #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimodm
force-pushed
the
refactor/mempool-closure
branch
from
c85f2ad to
43a5927
Compare
piotrm50
reviewed
Aug 4, 2023
piotrm50
reviewed
Aug 4, 2023
piotrm50
reviewed
Aug 10, 2023
piotrm50
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also offers a refactor of Inputs into an interface container called
State. An UTXO or a Context state complies instead with extended interfaces calledOutputStateandContextStaterespectively.Simarly, when a state managed to get resolved, its metadata state is wrapped in a
OutputStateMetadataandContextStateMetadatainterfaces respectively.The Mempool now is able to "wait" for the resolution of context inputs, wherever they might be according to the above mentioned interfaces, and passes the resolved contexts to the VM for cross-validation and transition execution. Currently, the only context input that can be passed resolved is the CommitmentInput (called
timeReferencein the VM context); in fact, BIC and Reward inputs rely on other inputs for their resolution and intrinsic validation: input commitment for Accounts, and UTXO input with staking or delegation feature for the Reward inputs.Depends on iotaledger/iota.go#474
Resolves #159