Description of change

Together with @semenov-vladyslav to investigate the AuthorityStore deprecated codes again, and in order to enable get the CheckpointSequenceNumber by the transaction digest, the old deprecated codes need to be reverted, because there is no other tables storing the relationship between the digest and epochId, or digest and CheckpointSequenceNumber in old epochs. Also the deprecated_multi_get_transaction_checkpoint/deprecated_get_transaction_checkpoint /deprecated_insert_finalized_transactions/executed_transactions_to_checkpoint/checkpoint_cache are coupled together. The easiest/safest way might be just to revert them back.

Investigation

The error is triggered in JSON RPC ReadApi impl of get_transaction_block: the API response contains checkpoint sequence number and timestamp (of the checkpoint) which are fetched from AuthorityPerpetualTables::executed_transactions_to_checkpoint DB table via a number of traits and wrappers. The table is not used for any other purposes and was marked as deprecated (together with a number of related functions and trait methods that support this table) in favor of AuthorityEpochTables::executed_transactions_to_checkpoint which gets cleared after each epoch. The reason for deprecation is unclear. Maybe, the JSON RPC ReadApi was expected to change (eg. get rid of checkpoint sequence number), or the implementation was expected to change and not use the mentioned table.

1. Right now we do not wish to change JSON RPC ReadApi.
2. We can't reimplement it another way (eg. fetch checkpoint info from another table); there is AuthorityState::rest_index that might have the required info (it seems to be duplicated), but it is only optionally enabled, so we can't rely on it unconditionally.
3. The access to the table is hidden with traits and wrappers, so it's not possible to simplify access to it and still get rid of methods marked as deprecated.

So the only reasonable option is to revert the RP that removed the table and deprecated API. And rename functions to make it clearer that the checkpoint info is fetched from perpetual table and add a few comments explaining these few implementation details.

As for the testnet the simplest solutions is to resync nodes from genesis.

Links to any relevant issues

Fixed #4154

Type of change

• Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Local Testing

Passed the testing cargo nextest run -p iota-json-rpc-tests -E "test(#get_transaction_block)" locally.

 Nextest run ID a45927f8-cf75-464b-a4ea-a5110d5a6d8e with nextest profile: default
    Starting 1 test across 10 binaries (148 tests skipped)
        PASS [  14.656s] iota-json-rpc-tests::read_api get_transaction_block

Sync from Genesis Testing

1. Prepare empty db/live folder
2. Build this branch and run cargo run --release --bin iota-node -- --config-path fullnode.yaml
3. Successfully sync without crashing
4. Query the old checkpoint and it returns checkpoints belonging to epoch 0.

curl 'http://iota-test-node-0.iota.works:9000/' \
 -H 'content-type: application/json' \
 --data-raw '{"jsonrpc":"2.0","id":12,"method":"iotax_queryTransactionBlocks","params": [
   {
     "filter": {"FromAddress": "0x0000000000000000000000000000000000000000000000000000000000000000"},
     "options": {"showInput": true}
   },
   null,
   10,
   false
 ]}' | json_pp | grep checkpoint

6. Get the correct output

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11637  100 11375  100   262  26006    599 --:--:-- --:--:-- --:--:-- 26629
            "checkpoint" : "0",
            "checkpoint" : "4",
            "checkpoint" : "1",
            "checkpoint" : "2",
            "checkpoint" : "2",
            "checkpoint" : "6",
            "checkpoint" : "8",
            "checkpoint" : "11",
            "checkpoint" : "13",
            "checkpoint" : "16",

Sync in the middle of the epoch testing

1. Use the iotaledger/iota-node:v0.7.2-rc image to sync to the last checkpoint.
2. Shut the node down, and remain all the live folder
3. Apply this reverting change, build and run cargo run --release --bin iota-node -- --config-path fullnode.yaml
4. Successfully sync without crashing
5. Query the old checkpoint and it works

  curl 'http://iota-test-node-0.iota.works:9000/' \
  -H 'content-type: application/json' \
  --data-raw '{"jsonrpc":"2.0","id":12,"method":"iotax_queryTransactionBlocks","params": [
    {
      "filter": {"FromAddress": "0x0000000000000000000000000000000000000000000000000000000000000000"},
      "options": {"showInput": true}
    },
    "7FoK3eUdLeRhpsyCyMqEJ5coKX2A4eAhrA3AqKWJWvex",
    2,
    false
  ]}' | json_pp | grep checkpoint

7. Get the correct output

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2301  100  1998  100   303   3116    472 --:--:-- --:--:-- --:--:--  3584
            "checkpoint" : "1075228",
            "checkpoint" : "1075228",

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

• I have followed the contribution guidelines for this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked that new and existing unit tests pass locally with my changes