Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rust toolchain to 1.82 #4165

Open
muXxer opened this issue Nov 20, 2024 · 2 comments
Open

Upgrade rust toolchain to 1.82 #4165

muXxer opened this issue Nov 20, 2024 · 2 comments
Assignees
Labels
team-core-node Issues related to the Core Node team

Comments

@muXxer
Copy link
Contributor

muXxer commented Nov 20, 2024

Currently the release-v0.7.0 docker containers are build with the latest stable rust version, which is 1.82 at this point in time.
This is due to the fact that we are using the rust:latest images in the build step, and because we don't copy the rust-toolchain.toml with the actual used toolchain version into the containers. This will be fixed with #4044

Nevertheless we should upgrade the used rust toolchain version to the latest released stable version of rust.
This should be done after #3705 is merged to develop.

@muXxer muXxer added the team-core-node Issues related to the Core Node team label Nov 20, 2024
@muXxer muXxer added this to the Post-Testnet Launch v0.8.x-rc milestone Nov 20, 2024
@gokhan-simsek-iota
Copy link

gokhan-simsek-iota commented Nov 22, 2024

@muXxer I started with my local, upgraded iota/rust-toolchain.toml to 1.82 and running cargo clippy. Will run RUSTFLAGS="--cfg msim" cargo clippy next.

Tried to find how exactly we run clippy, I am guessing this is the place: https://github.com/iotaledger/iota/blob/391a28bf51bd9ac1ca7ea3f516a8a755a9951315/scripts/slipstream/slipstream.py#L609C1-L612C72 -> # Run cargo clippy def run_cargo_clippy(panic_on_errors):

Opening a PR like this #3705 to trigger the CI might be also an option or run CI scripts locally to understand the whole process.

@thibault-martinez
Copy link
Member

Tried to find how exactly we run clippy

FYI in #4180 we are introducing a new clippy job for msim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-core-node Issues related to the Core Node team
Projects
None yet
Development

No branches or pull requests

3 participants