Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: split iota-transaction-builder into multiple files #4170

Closed
Thoralf-M opened this issue Nov 21, 2024 · 2 comments
Closed

Refactor: split iota-transaction-builder into multiple files #4170

Thoralf-M opened this issue Nov 21, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers team-dev-tools Issues related to the Developer Tools Team

Comments

@Thoralf-M
Copy link
Member

Description

Split lib.rs in iota-transaction-builder into multiple files

Motivation

Better overview if it's not just one large file and logically separated

Requirements

  1. Move request_add_stake(), request_withdraw_stake(), request_add_timelocked_stake(), request_withdraw_timelocked_stake() in a stake.rs file
  2. Move select_gas(), get_object_arg(), input_refs(), resolve_and_checks_json_args(), get_object_ref(), get_object_ref_and_type() in a utils.rs file
  3. Move publish_tx_kind(), publish(), upgrade_tx_kind(), upgrade() in a package.rs file

Open questions (optional)

Anyone has better suggestions for the file names?

Are you planning to do it yourself in a pull request?

No.

@Thoralf-M Thoralf-M added good first issue Good for newcomers team-dev-tools Issues related to the Developer Tools Team labels Nov 21, 2024
@sarahagib
Copy link
Contributor

Hi, my name is Sarah and I am an engineering student looking for a good first issue. If no one is already working on this issue, I would like to be assigned.

@thibault-martinez
Copy link
Member

Hi, my name is Sarah and I am an engineering student looking for a good first issue. If no one is already working on this issue, I would like to be assigned.

Hi Sarah, it's yours! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers team-dev-tools Issues related to the Developer Tools Team
Projects
None yet
Development

No branches or pull requests

3 participants