Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use saturating_add in shared_object_congestion_tracker.rs #4177

Open
muXxer opened this issue Nov 21, 2024 · 1 comment
Open

Use saturating_add in shared_object_congestion_tracker.rs #4177

muXxer opened this issue Nov 21, 2024 · 1 comment
Labels
team-core-node Issues related to the Core Node team

Comments

@muXxer
Copy link
Contributor

muXxer commented Nov 21, 2024

SUI fixed some overflows in the shared object congestion tracker.
We should fix those as well, and go through the rest of the code base if there are similar bugs.

MystenLabs/sui@837bf41
MystenLabs/sui@a139ef2

I'm wondering about the change with the <=, I think they refer to that with 0-cost tx, but what exactly is a 0-cost tx?

@muXxer muXxer added the team-core-node Issues related to the Core Node team label Nov 21, 2024
@muXxer muXxer added this to the Post-Testnet Launch v0.8.x-rc milestone Nov 21, 2024
@cuileri
Copy link

cuileri commented Nov 21, 2024

I'm wondering about the change with the <=, I think they refer to that with 0-cost tx, but what exactly is a 0-cost tx?

Since the active cost mode is the GasBudget mode, one could specify a high budget to cause overflow. Since they used saturating_add to address this issue, now it's possible that a transaction will not increase an already saturated number. So the problem is not 0-cost transactions but rather continuing to evaluate transactions after saturation occurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-core-node Issues related to the Core Node team
Projects
None yet
Development

No branches or pull requests

2 participants