Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning a local project #37

Open
jtmoulia opened this issue Mar 21, 2019 · 2 comments
Open

Scanning a local project #37

jtmoulia opened this issue Mar 21, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jtmoulia
Copy link

jtmoulia commented Mar 21, 2019

I'm interested in using this tool, but our code is hosted on GitLab rather than GitHub.

My thought is that if foss-finder can scan a local project it'll work independent of where the code is hosted.

Nifty tool!

@timburke
Copy link
Member

Hi @jtmoulia

That would be really useful. It looks like it would be a fairly quick change as well:

The only function the needs to change is get_dir_content to support a fully local path (maybe when repo=None):

and then an update to the parser to not enforce passing github credentials:

It looks like all of the underlying scanning logic doesn't rely on the code being hosted on github at all.
We don't have bandwidth to add this feature in the near future but a PR would be very welcome and at some point we're planning a refactor that would allow natively targeting various providers like GitLab and fully local in a generic way but that doesn't have a timeline attached to it at this point.

@timburke timburke added enhancement New feature or request good first issue Good for newcomers labels Mar 21, 2019
@jtmoulia
Copy link
Author

Thanks for the info @timburke -- hopefully I can make the changes in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants