Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI #52

Open
2 tasks
xpt1x opened this issue Oct 20, 2021 · 1 comment
Open
2 tasks

Add CI #52

xpt1x opened this issue Oct 20, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@xpt1x
Copy link
Contributor

xpt1x commented Oct 20, 2021

CI should be there with basic tests/checks related to addition to assets

  • Must include verification of added asset's symbol existence on coingecko
  • Should check if every asset has required props ( can be done with tsc )
@davepuchyr
Copy link
Contributor

Note: Use travis for this, not GitHub Actions or any other CI. Why? We are a travis shop. There's no justification of adding another CI driver to the mix.

@xpt1x xpt1x added the enhancement New feature or request label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davepuchyr @xpt1x