Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement simulation tests #44

Open
orkunkl opened this issue May 5, 2020 · 1 comment
Open

Implement simulation tests #44

orkunkl opened this issue May 5, 2020 · 1 comment
Assignees

Comments

@orkunkl
Copy link
Contributor

orkunkl commented May 5, 2020

We need to implement simulation tests to make sure everything works correctly

Requirements:

  • 1
@fdymylja
Copy link
Contributor

fdymylja commented May 5, 2020

What we need.

Each of our module has a keeper.

The keeper relies on other keepers.

As long as the keepers are our own we can init them from within, the problem arises when we need cosmos-sdk default keepers, who then have dependencies with their own keepers.

Initting them from scratch would not make sense because it'd be tedious and would require a really careful approach.

Instead we need to rely on the simulation.

So the requirements we need are the following, considering that the domain.Keeper relies on configuration.Keeper and supply.Keeper:

  1. check that an action performed on the domain keeper is allowed by the configuration state in the configuration module (tests are already written in each handler test file (file that ends with _test.go) in domain module and are mapped based on what they're doing and what they're checking so it's easy to understand the purpose).
  2. check that an action performed on the domain keeper is allowed by the supply module ( this is useful to test in case the account has not enough coins to pay fees to process a msg).

@fdymylja fdymylja mentioned this issue May 6, 2020
@orkunkl orkunkl self-assigned this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants