Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cob_scan_unifier is not merging complete scans in simulation #53

Closed
benmaidel opened this issue Sep 17, 2015 · 4 comments
Closed

cob_scan_unifier is not merging complete scans in simulation #53

benmaidel opened this issue Sep 17, 2015 · 4 comments

Comments

@benmaidel
Copy link
Member

scan unifier produce gap on the back of cob4-2
screenshot from 2015-09-17 14 01 09

@ipa-frm @ipa-mig

@mgruhler
Copy link
Member

hmm, also, there is a z-offset (which will probably not be a problem for our use-cases... but we should change that anyways...

@benmaidel
Copy link
Member Author

the z-offset seems to be ok. Imagine the scanners are mounted in different z positions (eg. our BMW). So transform the scans to the ground is ok, from my opinion. A better solution would be the usage of a point cloud instead a merged scan message.

@benmaidel
Copy link
Member Author

https://github.com/iralabdisco/ira_laser_tools
there you can find a tool with the same purpose as cob_scan_unifier.
Difference:

  • no gaps
  • dynamic reconfigure
  • offers point cloud 2 as well

Perhaps we should stick to this package? We could even copy the code from this package to our repo, because it has no license at all.

@benmaidel
Copy link
Member Author

This issue was moved to ipa320/cob_driver#249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants