Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update libp2p to 0.51.0 #43

Closed
wants to merge 7 commits into from

Conversation

dariusc93
Copy link
Contributor

No description provided.

@dariusc93 dariusc93 marked this pull request as ready for review February 25, 2023 16:33
Copy link

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks for doing the work here.

Cargo.toml Show resolved Hide resolved
@oblique
Copy link

oblique commented May 5, 2023

I am interested in this change too, thanks for working on it. Is there anything blocking it from being merged?

@dariusc93
Copy link
Contributor Author

I am interested in this change too, thanks for working on it. Is there anything blocking it from being merged?

As far as I know, nothing is blocking it. Might be that the maintainers are busy and this havent been on their priority

"ed25519",
"async-std",
] }
multihash = { version = "0.17.0", default-features = false, features = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxinden I’m slightly confused: the other PR #46 upgraded to 0.18 and only one of those choices can be correct.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.parse()
.unwrap();
let multiaddr: Multiaddr = "/ip4/95.217.194.97/tcp/8008".parse().unwrap();
let multiaddr: Multiaddr = "/ip4/104.131.131.82/tcp/4001".parse().unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is always such a pain — can you guarantee that this address will keep working?

Copy link
Contributor Author

@dariusc93 dariusc93 May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot guarantee it will keep working but it has been updated [to the latest kubo] and have been stable so far in use. I recall updating it due to the previous address causing the test to fail.

@dariusc93
Copy link
Contributor Author

This PR is replaced by #47

@dariusc93 dariusc93 closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants