-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update libp2p to 0.51.0 #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 thanks for doing the work here.
I am interested in this change too, thanks for working on it. Is there anything blocking it from being merged? |
As far as I know, nothing is blocking it. Might be that the maintainers are busy and this havent been on their priority |
"ed25519", | ||
"async-std", | ||
] } | ||
multihash = { version = "0.17.0", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rust-libp2p
v0.51.3
uses multihash
v0.17.0
.
.parse() | ||
.unwrap(); | ||
let multiaddr: Multiaddr = "/ip4/95.217.194.97/tcp/8008".parse().unwrap(); | ||
let multiaddr: Multiaddr = "/ip4/104.131.131.82/tcp/4001".parse().unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is always such a pain — can you guarantee that this address will keep working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot guarantee it will keep working but it has been updated [to the latest kubo] and have been stable so far in use. I recall updating it due to the previous address causing the test to fail.
This PR is replaced by #47 |
No description provided.