This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
chore: add gossipsub grafting delay #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of libp2p/go-libp2p-pubsub#331 we have to wait for a the gossipsub peer to become grafted before sending messages we expect to be recieved. There's no way to tell from the API which peers are grafted so we just have to add an abitrary wait and hope it happens during that time window. Also refactors the pubsub tests to remove duplicated code and the ipns-pubsub tests to use named variables instead of array indices for readability.
achingbrain
force-pushed
the
fix/wait-for-longer-in-ci
branch
from
314141e
to
8fc2a81
Compare
|
This doesn't seem to fix the problem after all. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of libp2p/go-libp2p-pubsub#331 we have to wait for a the gossipsub peer to become grafted before sending messages we expect to be received. There's no way to tell from the API which peers are grafted so we just have to add an arbitrary wait and hope it happens during that time window.
Also refactors the pubsub tests to remove duplicated code and the ipns-pubsub tests to use named variables instead of array indices for readability.