wip: running tests in playwright-test #846
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this does not work yet, maybe due to custom webpack config or somethign else. the goal for using playwright-test would be running tests in the same web context, with real webextension APIs (right now we use mocks, which not always match real world behavior) this is something we may pick up in spare time notes to self: - for now playwright-test can only run Chromium extension mode, Firefox is not supported :-( - no headless mode for running in extension context, browser window is always shown
lidel
added
the
kind/maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
playwright-testwhich enables us to run mocha tests in real WebExtension context.Motivation
Right now we use mocks, which not always match real world behavior, which is known to be different in Firefox and Chromium (APIs diverge slightly).
Running in real WebExtension context would let us catch those discrepancies.
Caveats
Firefox is not supported due to missing
this.browser.targets is not a function