-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: offline error page #920
base: main
Are you sure you want to change the base?
Conversation
@lidel - No need to look at code for this yet, just wanted to confirm this direction with you before moving the text into i18n keys. Note that the explanatory text is intended to change depending on error context, so a wired-up version of this would only display one text-plus-button(s) combo (either "Your custom gateway ..." or "You tried to load ..."). Do you mind a quick look? Thanks 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The direction looks great, love the icon, thank you 🙏
Sidenote: this screen will be useful not only for recovering when local gateway is down. We will have two types of errors:
- Local gateway is offline
- Remote server error
- if DNSLink is present and original server is down, Companion is able to recover by loading DNSLink website from the local gateway (example below).
@lidel -- I think this is ready for you to wire up at your leisure. CI is failing due to missing manifest.json but looks like that's intentionally excluded? Let me know if there's anything else I can do. |
About
This PR adds a more friendly and useful error page when either user's custom gateway is offline, or user tries to load a DNSLink-enabled site from an unavailable remote host.
Closes #806.
To do:
window.location.hash