[gui error report] TypeError: Use delete() to clear values

[Eninspace]

Steps to reproduce:

• Change app language

Specifications

• OS: win32 10.0.22000
• IPFS Desktop Version: 0.24.1
• Electron Version: 19.0.9
• Chrome Version: 102.0.5005.167

Error

TypeError: Use `delete()` to clear values
    at ElectronStore.set (C:\Users\****\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\conf\dist\source\index.js:165:19)
    at IpcMainImpl.<anonymous> (C:\Users\****\AppData\Local\Programs\IPFS Desktop\resources\app.asar\src\i18n.js:31:11)
    at IpcMainImpl.emit (node:events:538:35)
    at IpcMainImpl.<anonymous> (C:\Users\****\AppData\Local\Programs\IPFS Desktop\resources\app.asar\src\i18n.js:34:13)

[whizzzkid]

Thanks for submitting this issue @Eninspace, confirmed this is a bug.

CC: @SgtPooki

[Amit-Dagar]

Anyone resolved this yet ??

[SgtPooki]

Error is coming from https://github.com/sindresorhus/conf/blob/217f062b5e54ce7060ec2335d717f4ae6bf8086d/source/index.ts#L189, which is only used by electron-store in our app.

╰─ ✔ ❯ npm why conf
[email protected]
node_modules/conf
  conf@"^10.2.0" from [email protected]
  node_modules/electron-store
    electron-store@"^8.1.0" from the root project

electron-store is only used in the file

ipfs-desktop/src/common/store.js

Line 2 in 7193abb

const Store = require('electron-store')

---

store.set(unknownKey, unknownValue) is being called where unknownValue===undefined

I'm looking into this now

╰─ ✔ ❯ rg -F 'store.set' -g '!*.spec.*'
src/move-repository-location.js
80:    store.set('ipfsConfig', config)

src/automatic-gc.js
28:  store.set('ipfsConfig.flags', newFlags)

src/i18n.js
31:    store.set('language', lang)

src/webui/index.js
95:    store.set('window.width', dim[0])
96:    store.set('window.height', dim[1])
122:    store.set(CONFIG_KEY, true)
126:    store.set(CONFIG_KEY, newValue)

src/daemon/index.js
66:      store.set('ipfsConfig', config)

src/common/store.js
29:      store.set('ipfsConfig.flags', defaults.ipfsConfig.flags)
38:      store.set('automaticGC', true)
52:      store.set('ipfsConfig.flags', flags)
58:      store.set('ipfsConfig.flags', flags)
69:      store.set('ipfsConfig.flags', flags)

src/daemon/config.js
237:      store.set(REVISION_KEY, REVISION)
243:  store.set(REVISION_KEY, REVISION)

src/tray.js
375:    store.set(CONFIG_KEYS.MONOCHROME_TRAY_ICON, newValue)

src/custom-ipfs-binary.js
40:    store.set(SETTINGS_KEY, filePaths[0])

src/enable-namesys-pubsub.js
28:  store.set('ipfsConfig.flags', newFlags)

src/utils/create-toggler.js
12:      store.set(settingsOption, newValue)

src/enable-pubsub.js
28:  store.set('ipfsConfig.flags', newFlags)