Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC API reference: document global flags #1084

Open
aschmahmann opened this issue Mar 18, 2022 · 4 comments
Open

RPC API reference: document global flags #1084

aschmahmann opened this issue Mar 18, 2022 · 4 comments
Labels
need/author-input Needs input from the original author need/maintainers-input Needs input from the current maintainer(s) needs/triage status/blocked Unable to be worked further until needs are met

Comments

@aschmahmann
Copy link
Contributor

aschmahmann commented Mar 18, 2022

Flags like --offline , --cid-base, --timeout, etc. are not documented in https://docs.ipfs.io/reference/http/api/ likely because they are scraping the individual commands which are not showing the global flags ipfs/kubo#6640.

Whether this gets fixed by manually changing things here or by resolving the linked go-ipfs issue is a matter of prioritization although I'd like to think at least documenting what's going manually is better than waiting on the coding fix here.

IMO we should put in some hard coded text for now and rip it out later.

Note: I'm not sure how we want to handle this in documentation but IIRC the global flags are not truly respected everywhere. e.g. this issue on --offline ipfs/kubo#6002.

cc @lidel since IIRC you're looking into a PR regarding other metadata changes to go-ipfs-cmds to help with documentation

@aschmahmann aschmahmann added the need/triage Needs initial labeling and prioritization label Mar 18, 2022
@lidel
Copy link
Member

lidel commented Mar 22, 2022

My vote is to solve this in tools/http-api-docs: we should be able to programmatically read top-level flags (ones listed in ipfs --help) and use them to generate a new markdown section at the top of HTTP RPC API reference docs, before enumeration of specific commands.

If someone wants to contribute this, start by poking around tools/http-api-docs/endpoints.go to get metadata from the root of all commands, and then generate new markdown around formatter.go / markdown.go

@lidel lidel added dif/easy Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or an improvement to an existing feature effort/hours Estimated to take one or several hours and removed need/triage Needs initial labeling and prioritization labels Mar 22, 2022
@lidel lidel changed the title HTTP API missing flags that apply to commands generically RPC API reference: document global flags Mar 22, 2022
@johnnymatthews johnnymatthews moved this to Needs triage in Protocol Docs Mar 29, 2022
@Annamarie2019 Annamarie2019 added P3 Low: Not priority right now P2 Medium: Good to have, but can wait until someone steps up and removed P3 Low: Not priority right now labels Mar 31, 2022
@Annamarie2019 Annamarie2019 moved this from Needs triage to Backlog in Protocol Docs Mar 31, 2022
@ElPaisano
Copy link
Contributor

@lidel @aschmahmann triaging old issues:

I poked around https://docs.ipfs.io/reference/http/api/ and it looks like the flags called out here are still missing. We can document manually if need be, but it sounds like the automation is the best thing to focus on here. That being said, is this still relevant? Maybe the flags are in there now but I missed them? Thanks

@ElPaisano ElPaisano added status/deferred Conscious decision to pause or backlog and removed P2 Medium: Good to have, but can wait until someone steps up labels Apr 4, 2023
@ElPaisano
Copy link
Contributor

@lidel @aschmahmann re-flagging this (very old) issue. Can I get your thoughts? If this isn't relevant still, I can close.

@ElPaisano ElPaisano added need/author-input Needs input from the original author need/maintainers-input Needs input from the current maintainer(s) status/blocked Unable to be worked further until needs are met needs/triage and removed dif/easy Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or an improvement to an existing feature effort/hours Estimated to take one or several hours status/deferred Conscious decision to pause or backlog labels Aug 21, 2023
@lidel
Copy link
Member

lidel commented Aug 22, 2023

This is still relevant, but also lower (P2?) priority.
Fwiw my pointers from #1084 (comment) are still valid if someone has time to pick this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author need/maintainers-input Needs input from the current maintainer(s) needs/triage status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

No branches or pull requests

4 participants