Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor extended provider builder to simply build advertisements #319

Open
masih opened this issue Jan 18, 2023 · 0 comments
Open

Refactor extended provider builder to simply build advertisements #319

masih opened this issue Jan 18, 2023 · 0 comments
Assignees
Labels

Comments

@masih
Copy link
Member

masih commented Jan 18, 2023

Right now it is possible for extended provider builder API to be used for building regular ads with redundant entries. For example, if there are no extended provides added to the builder, it always generates ads with extended providers that have duplicate extended provider info as the root.

We can avoid all of this, by refactoring the code, such that there is just ad builder that does the right thing when extended providers are added. That also makes it easier for clients to use the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants