-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch unknown providers at /routing/v1/providers to peer schema #147
Comments
Of course 👍 OK to action this next week? |
@masih yes, any time in next 2 weeks will be 👍 |
The /routing/v1/providers/ endpoint now reports unknown schema as "peer", and omits the Protocol. Testing was manual testing using example in issue. Fixes #147
@lidel Question: is there anything to coordinate on in terms of breaking changes? Cc @gammazero |
@masih no, afaik the change is that Kubo 0.22 is ignoring Switching from |
The /routing/v1/providers/ endpoint now reports unknown schema as "peer", and omits the Protocol. Testing was manual testing using example in issue. Fixes #147
Currently, cid.contact returns all HTTP nft.storage announcements like this (example):
The problem is that results with
"Schema":"unknown"
are being ignored by boxo client (conformed in ipfs/boxo#422 (comment)), and we would like Kubo and other users of boxo client library to accessID
andAddrs
information present there (+ setting standard for doing the same in JS in Helia).@masih would it be possible to change to
Schema: "peer"
(from IPIP-417) for these /routing/v1/providers responses?All we need is:
The text was updated successfully, but these errors were encountered: