-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with trait typing #863
Comments
Oh, and one more issue, remove_cell_tags = Set(
Unicode(),
default_value=[],
help=(
"Tags indicating which cells are to be removed,"
"matches tags in ``cell.metadata.tags``."
),
).tag(config=True)
|
Overall this is a positive change and I don't think we should revert based on these shortcomings. |
Another one: latex_command = List(
["xelatex", "{filename}", "-quiet"], help="Shell command used to compile latex."
).tag(config=True) |
Nice to fix: _exporters = Dict() |
|
style = Union(
[Unicode("default"), Type(klass=Style)],
help="Name of the pygments style to use",
default_value=JupyterStyle,
).tag(config=True) |
safe_output_keys = Set(
config=True,
default_value={
"metadata", # Not a mimetype per-se, but expected and safe.
"text/plain",
"text/latex",
"application/json",
"image/png",
"image/jpeg",
},
help="Cell output mimetypes to render without modification",
) |
Our helper functions should have type hints:
|
As these issues get resolved, it's probably worth adding some guidance to the docs. A specific case: will it be possible for downstreams to use the Also noted over on #864 (comment), is there a future where |
I don't see how the specific types exposed in I view what we had prior to 5.10 as wholly deficient, and not worth supporting from a typing perspective. For example, the |
Hi @blink1073 , Thank you for opening the issue!. i'm currently traveling, so I cannot work on this now. Nice to see this is already catching the None cases! Regards, Maarten |
In #818 we introduced typing of traits. While testing the feature with
nbconvert
, I saw two issues relating to overloads:The source code was:
And:
Where the source code was:
We should use these failures as test cases with the fixes.
The text was updated successfully, but these errors were encountered: