Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that triggers the len error #151

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Test that triggers the len error #151

merged 2 commits into from
Sep 12, 2024

Conversation

gordonwatts
Copy link
Member

@gordonwatts gordonwatts commented Sep 12, 2024

  • Added len as an "internal" function, much the way abs is already added.
  • Added small test to make sure this fixes the warning we've been seeing.

Fixes #146

@gordonwatts gordonwatts self-assigned this Sep 12, 2024
@gordonwatts gordonwatts added the bug Something isn't working label Sep 12, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (29a3406) to head (b51dae6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   96.93%   96.94%           
=======================================
  Files          15       15           
  Lines        1338     1340    +2     
=======================================
+ Hits         1297     1299    +2     
  Misses         41       41           
Flag Coverage Δ
unittests 96.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gordonwatts gordonwatts marked this pull request as ready for review September 12, 2024 21:49
@gordonwatts gordonwatts merged commit b67b122 into master Sep 12, 2024
32 checks passed
@gordonwatts gordonwatts deleted the bug/len branch September 12, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The len call generates a type error
2 participants