Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Range is set improperly for S3_copy_object_range #5

Closed
2 tasks done
JustinKyleJames opened this issue Sep 22, 2020 · 1 comment
Closed
2 tasks done

Range is set improperly for S3_copy_object_range #5

JustinKyleJames opened this issue Sep 22, 2020 · 1 comment
Assignees
Labels

Comments

@JustinKyleJames
Copy link

JustinKyleJames commented Sep 22, 2020

  • v4
  • master

The end range for the following should be params->startByte + params->byteCount - 1.

Bytes in the middle are being written more than once and then it attempts to write one byte extra.

libs3/src/request.c

Lines 399 to 403 in 59b6237

if (params->byteCount > 0) {
headers_append(1, "x-amz-copy-source-range: bytes=%lld-%lld",
(unsigned long long) params->startByte,
(unsigned long long) (params->startByte + params->byteCount) );
}

trel pushed a commit to JustinKyleJames/libs3 that referenced this issue Dec 5, 2020
trel pushed a commit to trel/libs3 that referenced this issue Dec 5, 2020
trel pushed a commit to trel/libs3 that referenced this issue Dec 5, 2020
@trel
Copy link
Member

trel commented Dec 8, 2020

this is the same as upstream bji#102

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants