address review comments

ironcore-dev · Oct 28, 2024 · ae861fd · ae861fd
1 parent 4cfefcf
commit ae861fd
Show file tree

Hide file tree

Showing 13 changed files with 7 additions and 7 deletions.
diff --git a/...ases/ephemeral-machine/kustomization.yaml → ...th-ephemeral-resources/kustomization.yaml b/...ases/ephemeral-machine/kustomization.yaml → ...th-ephemeral-resources/kustomization.yaml
diff --git a/.../e2e/bases/ephemeral-machine/machine.yaml → ...ine-with-ephemeral-resources/machine.yaml b/.../e2e/bases/ephemeral-machine/machine.yaml → ...ine-with-ephemeral-resources/machine.yaml
diff --git a/.../e2e/bases/ephemeral-machine/network.yaml → ...ine-with-ephemeral-resources/network.yaml b/.../e2e/bases/ephemeral-machine/network.yaml → ...ine-with-ephemeral-resources/network.yaml
diff --git a/...s/nonephemeral-machine/kustomization.yaml → ...nonephemeral-resources/kustomization.yaml b/...s/nonephemeral-machine/kustomization.yaml → ...nonephemeral-resources/kustomization.yaml
diff --git a/...e/bases/nonephemeral-machine/machine.yaml → ...-with-nonephemeral-resources/machine.yaml b/...e/bases/nonephemeral-machine/machine.yaml → ...-with-nonephemeral-resources/machine.yaml
diff --git a/...e/bases/nonephemeral-machine/network.yaml → ...-with-nonephemeral-resources/network.yaml b/...e/bases/nonephemeral-machine/network.yaml → ...-with-nonephemeral-resources/network.yaml
diff --git a/...onephemeral-machine/networkinterface.yaml → ...ephemeral-resources/networkinterface.yaml b/...onephemeral-machine/networkinterface.yaml → ...ephemeral-resources/networkinterface.yaml
diff --git a/...bases/nonephemeral-machine/virtualIP.yaml → ...ith-nonephemeral-resources/virtualIP.yaml b/...bases/nonephemeral-machine/virtualIP.yaml → ...ith-nonephemeral-resources/virtualIP.yaml
diff --git a/...2e/bases/nonephemeral-machine/volume.yaml → ...e-with-nonephemeral-resources/volume.yaml b/...2e/bases/nonephemeral-machine/volume.yaml → ...e-with-nonephemeral-resources/volume.yaml
diff --git a/...machine-with-ephemeral-resource/README.md → ...achine-with-ephemeral-resources/README.md b/...machine-with-ephemeral-resource/README.md → ...achine-with-ephemeral-resources/README.md
@@ -1,4 +1,4 @@
-# Machine Sample deployement
+# Machine with ephemeral resources
 
 This example deploys a `Machine` with `ephemeral` `volume` and `networkinterface`. 
 The following artifacts will be deployed in your namespace:   
@@ -15,7 +15,7 @@ The following artifacts will be deployed in your namespace:
 1. Adapt the `namespace` in `kustomization.yaml`
 2. Replace `your-user`, `your-pw-hash` and `your-ssh-key`s in the `ignition/ignition.yaml`
 3. Run `ignition/regenerate-ignition.sh`
-4. Create the below `patch-machine.yaml` in `machine-with-ephemeral-resource` folder with the desired `machineClassRef`, `machinePoolRef`, `volumeClassRef`, `volumePoolRef`, `image` etc. as per your environment
+4. Create the below `patch-machine.yaml` in `machine-with-ephemeral-resources` folder with the desired `machineClassRef`, `machinePoolRef`, `volumeClassRef`, `volumePoolRef`, `image` etc. as per your environment
 
 ```
 apiVersion: compute.ironcore.dev/v1alpha1

diff --git a/...ith-ephemeral-resource/kustomization.yaml → ...th-ephemeral-resources/kustomization.yaml b/...ith-ephemeral-resource/kustomization.yaml → ...th-ephemeral-resources/kustomization.yaml
@@ -5,4 +5,4 @@ namespace: test
 
 resources:
 - ../bases/ignition
-- ../bases/ephemeral-machine
+- ../bases/machine-with-ephemeral-resources
diff --git a/...ine-with-non-ephemeral-resource/README.md → ...ne-with-non-ephemeral-resources/README.md b/...ine-with-non-ephemeral-resource/README.md → ...ne-with-non-ephemeral-resources/README.md
@@ -1,4 +1,4 @@
-# `Machine` non ephemeral resources
+# `Machine` with non ephemeral resources
 
 This example deploys a `Machine` with `non-ephemeral` `volume` and `networkinterface`. 
 The following artifacts will be deployed in your namespace:   
@@ -15,7 +15,7 @@ The following artifacts will be deployed in your namespace:
 1. Adapt the `namespace` in `kustomization.yaml`
 2. Replace `your-user`, `your-pw-hash` and `your-ssh-key` in the `ignition/ignition.yaml`
 3. Run `ignition/regenerate-ignition.sh`
-4. Create the below `patch-machine.yaml` in `machine-with-non-ephemeral-resource` folder with the desired `machineClassRef` and `machinePoolRef` as per your environment
+4. Create the below `patch-machine.yaml` in `machine-with-non-ephemeral-resources` folder with the desired `machineClassRef` and `machinePoolRef` as per your environment
 
 ```
 apiVersion: compute.ironcore.dev/v1alpha1
@@ -29,7 +29,7 @@ spec:
     name: new-machinePool
 ```
 
-5. Create the below`patch-volume.yaml`in `machine-with-non-ephemeral-resource` folder with the desired `volumeClassRef`and `volumePoolRef` as per your environment
+5. Create the below`patch-volume.yaml`in `machine-with-non-ephemeral-resources` folder with the desired `volumeClassRef`and `volumePoolRef` as per your environment
 
 ```
 apiVersion: storage.ironcore.dev/v1alpha1

diff --git a/...non-ephemeral-resource/kustomization.yaml → ...on-ephemeral-resources/kustomization.yaml b/...non-ephemeral-resource/kustomization.yaml → ...on-ephemeral-resources/kustomization.yaml
@@ -5,4 +5,4 @@ namespace: test
 
 resources:
 - ../bases/ignition
-- ../bases/nonephemeral-machine
+- ../bases/machine-with-nonephemeral-resources