From c85ebabdb18615981c33387eed84f7f94853da33 Mon Sep 17 00:00:00 2001 From: Benjamin Alpert Date: Mon, 25 Nov 2024 14:28:48 +0100 Subject: [PATCH] do not use shorthand identifier flag --- broker/bucketbroker/cmd/bucketbroker/app/app.go | 2 +- broker/machinebroker/cmd/machinebroker/app/app.go | 2 +- broker/volumebroker/cmd/volumebroker/app/app.go | 2 +- poollet/bucketpoollet/cmd/bucketpoollet/app/app.go | 4 ++-- poollet/machinepoollet/cmd/machinepoollet/app/app.go | 4 ++-- poollet/volumepoollet/cmd/volumepoollet/app/app.go | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/broker/bucketbroker/cmd/bucketbroker/app/app.go b/broker/bucketbroker/cmd/bucketbroker/app/app.go index 52d186a1..c5663f6a 100644 --- a/broker/bucketbroker/cmd/bucketbroker/app/app.go +++ b/broker/bucketbroker/cmd/bucketbroker/app/app.go @@ -39,7 +39,7 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) { fs.StringVar(&o.Kubeconfig, "kubeconfig", o.Kubeconfig, "Path pointing to a kubeconfig file to use.") fs.StringVar(&o.Address, "address", "/var/run/iri-bucketbroker.sock", "Address to listen on.") - fs.Float32VarP(&o.QPS, "qps", "", defaults.QPS, "Kubernetes client qps.") + fs.Float32Var(&o.QPS, "qps", defaults.QPS, "Kubernetes client qps.") fs.IntVar(&o.Burst, "burst", defaults.Burst, "Kubernetes client burst.") fs.StringVar(&o.Namespace, "namespace", o.Namespace, "Target Kubernetes namespace to use.") diff --git a/broker/machinebroker/cmd/machinebroker/app/app.go b/broker/machinebroker/cmd/machinebroker/app/app.go index 93c1216c..e9c23ff1 100644 --- a/broker/machinebroker/cmd/machinebroker/app/app.go +++ b/broker/machinebroker/cmd/machinebroker/app/app.go @@ -54,7 +54,7 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) { fs.StringToStringVar(&o.BrokerDownwardAPILabels, "broker-downward-api-label", nil, "The labels to broker via downward API. "+ "Example is for instance to broker \"root-machine-uid\" initially obtained via \"machinepoollet.ironcore.dev/machine-uid\".") - fs.Float32VarP(&o.QPS, "qps", "", defaults.QPS, "Kubernetes client qps.") + fs.Float32Var(&o.QPS, "qps", defaults.QPS, "Kubernetes client qps.") fs.IntVar(&o.Burst, "burst", defaults.Burst, "Kubernetes client burst.") fs.StringVar(&o.Namespace, "namespace", o.Namespace, "Target Kubernetes namespace to use.") diff --git a/broker/volumebroker/cmd/volumebroker/app/app.go b/broker/volumebroker/cmd/volumebroker/app/app.go index b81e4af9..3aabbe9c 100644 --- a/broker/volumebroker/cmd/volumebroker/app/app.go +++ b/broker/volumebroker/cmd/volumebroker/app/app.go @@ -39,7 +39,7 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) { fs.StringVar(&o.Kubeconfig, "kubeconfig", o.Kubeconfig, "Path pointing to a kubeconfig file to use.") fs.StringVar(&o.Address, "address", "/var/run/iri-volumebroker.sock", "Address to listen on.") - fs.Float32VarP(&o.QPS, "qps", "", defaults.QPS, "Kubernetes client qps.") + fs.Float32Var(&o.QPS, "qps", defaults.QPS, "Kubernetes client qps.") fs.IntVar(&o.Burst, "burst", defaults.Burst, "Kubernetes client burst.") fs.StringVar(&o.Namespace, "namespace", o.Namespace, "Target Kubernetes namespace to use.") diff --git a/poollet/bucketpoollet/cmd/bucketpoollet/app/app.go b/poollet/bucketpoollet/cmd/bucketpoollet/app/app.go index 62c7b6a7..1007bc81 100644 --- a/poollet/bucketpoollet/cmd/bucketpoollet/app/app.go +++ b/poollet/bucketpoollet/cmd/bucketpoollet/app/app.go @@ -16,13 +16,13 @@ import ( ipamv1alpha1 "github.com/ironcore-dev/ironcore/api/ipam/v1alpha1" networkingv1alpha1 "github.com/ironcore-dev/ironcore/api/networking/v1alpha1" storagev1alpha1 "github.com/ironcore-dev/ironcore/api/storage/v1alpha1" - "github.com/ironcore-dev/ironcore/poollet/common/defaults" iri "github.com/ironcore-dev/ironcore/iri/apis/bucket/v1alpha1" iriremotebucket "github.com/ironcore-dev/ironcore/iri/remote/bucket" "github.com/ironcore-dev/ironcore/poollet/bucketpoollet/bcm" "github.com/ironcore-dev/ironcore/poollet/bucketpoollet/bem" bucketpoolletconfig "github.com/ironcore-dev/ironcore/poollet/bucketpoollet/client/config" "github.com/ironcore-dev/ironcore/poollet/bucketpoollet/controllers" + "github.com/ironcore-dev/ironcore/poollet/common/defaults" "github.com/ironcore-dev/ironcore/poollet/irievent" "github.com/ironcore-dev/ironcore/utils/client/config" @@ -95,7 +95,7 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) { fs.StringVar(&o.WatchFilterValue, "watch-filter", "", "Value to filter for while watching.") - fs.Float32VarP(&o.QPS, "qps", "", defaults.QPS, "Kubernetes client qps.") + fs.Float32Var(&o.QPS, "qps", defaults.QPS, "Kubernetes client qps.") fs.IntVar(&o.Burst, "burst", defaults.Burst, "Kubernetes client burst.") fs.IntVar(&o.MaxConcurrentReconciles, "max-concurrent-reconciles", 1, "Maximum number of concurrent reconciles.") } diff --git a/poollet/machinepoollet/cmd/machinepoollet/app/app.go b/poollet/machinepoollet/cmd/machinepoollet/app/app.go index 9357c176..035e71a8 100644 --- a/poollet/machinepoollet/cmd/machinepoollet/app/app.go +++ b/poollet/machinepoollet/cmd/machinepoollet/app/app.go @@ -18,10 +18,10 @@ import ( ipamv1alpha1 "github.com/ironcore-dev/ironcore/api/ipam/v1alpha1" networkingv1alpha1 "github.com/ironcore-dev/ironcore/api/networking/v1alpha1" storagev1alpha1 "github.com/ironcore-dev/ironcore/api/storage/v1alpha1" - "github.com/ironcore-dev/ironcore/poollet/common/defaults" computeclient "github.com/ironcore-dev/ironcore/internal/client/compute" iri "github.com/ironcore-dev/ironcore/iri/apis/machine/v1alpha1" iriremotemachine "github.com/ironcore-dev/ironcore/iri/remote/machine" + "github.com/ironcore-dev/ironcore/poollet/common/defaults" "github.com/ironcore-dev/ironcore/poollet/irievent" "github.com/ironcore-dev/ironcore/poollet/machinepoollet/addresses" machinepoolletclient "github.com/ironcore-dev/ironcore/poollet/machinepoollet/client" @@ -117,7 +117,7 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) { fs.StringVar(&o.WatchFilterValue, "watch-filter", "", "Value to filter for while watching.") - fs.Float32VarP(&o.QPS, "qps", "", defaults.QPS, "Kubernetes client qps.") + fs.Float32Var(&o.QPS, "qps", defaults.QPS, "Kubernetes client qps.") fs.IntVar(&o.Burst, "burst", defaults.Burst, "Kubernetes client burst.") fs.IntVar(&o.MaxConcurrentReconciles, "max-concurrent-reconciles", 1, "Maximum number of concurrent reconciles.") } diff --git a/poollet/volumepoollet/cmd/volumepoollet/app/app.go b/poollet/volumepoollet/cmd/volumepoollet/app/app.go index 6aa0187b..39825e51 100644 --- a/poollet/volumepoollet/cmd/volumepoollet/app/app.go +++ b/poollet/volumepoollet/cmd/volumepoollet/app/app.go @@ -96,7 +96,7 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) { fs.StringVar(&o.WatchFilterValue, "watch-filter", "", "Value to filter for while watching.") - fs.Float32VarP(&o.QPS, "qps", "", defaults.QPS, "Kubernetes client qps.") + fs.Float32Var(&o.QPS, "qps", defaults.QPS, "Kubernetes client qps.") fs.IntVar(&o.Burst, "burst", defaults.Burst, "Kubernetes client burst.") fs.IntVar(&o.MaxConcurrentReconciles, "max-concurrent-reconciles", 1, "Maximum number of concurrent reconciles.") }