Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate .spec.uuid in favor of .spec.systemUUID #144

Closed
afritzler opened this issue Oct 15, 2024 · 1 comment · Fixed by #195
Closed

Deprecate .spec.uuid in favor of .spec.systemUUID #144

afritzler opened this issue Oct 15, 2024 · 1 comment · Fixed by #195
Assignees
Labels
enhancement New feature or request

Comments

@afritzler
Copy link
Member

Summary

Since the system uuid is currently stored in the Server spec under uuid and leads to some confusion regarding the meaning of this field we might want to rename it. Suggestion would be to use .spec.systemUUID instead of .spec.uuid.

For backward compatibility we should deprecate the old field name and set both fields for now. Later we can set it to an empty string and remove it.

@afritzler afritzler added the enhancement New feature or request label Oct 15, 2024
@stefanhipfel stefanhipfel self-assigned this Oct 17, 2024
@stefanhipfel
Copy link
Contributor

stefanhipfel commented Oct 17, 2024

+kubebuilder:deprecatedversion can only bet set at the crd level, not field level.

so as far is I understand, one can only put it like this:

//+kubebuilder:deprecatedversion:warning="metal.ironcore.dev/v1alpha1 ServerSpec.UUID will be deprecated in version metal.ironcore.dev/v1alpha2, use ServerSpec.SystemUUID instead"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants