Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handling errors in the middle of handlers #375

Open
jinbpark opened this issue Oct 10, 2024 · 2 comments
Open

Properly handling errors in the middle of handlers #375

jinbpark opened this issue Oct 10, 2024 · 2 comments

Comments

@jinbpark
Copy link
Collaborator

e.g.,

listen!(mainloop, rmi::REC_CREATE, |arg, ret, rmm| {
   ...
   rmm.page_table.map(rec, true);   // map here
   ...
   rec.set_vtcr(prepare_vtcr(&rd)?);  // something goes wrong in the middle. --> we need to unmap "rec" in this case
}

analyze all handler functions in this context, and handle this error properly

@Harsh1s
Copy link

Harsh1s commented Dec 27, 2024

Hi there, @bitboom @jinbpark
I've been going through islet's codebase and documentation to participate in the "Strengthening Security through Fuzz Testing" mentorship project. Would it be fine if I try to work on this issue? I'm really excited to contribute to the islet project and want to get started with contributions as soon as possible.

@jinbpark
Copy link
Collaborator Author

jinbpark commented Jan 2, 2025

@Harsh1s

Thanks for your interest in this issue.
It would be great if you try to work on this issue!

One thing I want to ask you is-
please make and share a draft PR first in order to just show what your high-level approach is to this problem.
Then, we can have a discussion and make a consensus about a high-level approach before applying a solution.

What I want to see from the draft PR looks like--

  • The draft PR description enumerates possible approaches to this problem and briefly compares them.

    • e.g., Approach-1: ... --> Approach-1 is more secure, but less convenient
    • e.g., Approach-2: ... --> Approach-2 is less secure, but more convenient for developers, that is to say, not many codes need to be modified to adopt this approach.
  • The draft PR description explains the approach you decide to go for and why you think the approach is the best.


If you have any questions on it, feel free to ask~!
Thanks again for your interest of contributing to this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants