Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider implementing units in raw_data #83

Open
sebkopf opened this issue Oct 29, 2019 · 0 comments
Open

consider implementing units in raw_data #83

sebkopf opened this issue Oct 29, 2019 · 0 comments

Comments

@sebkopf
Copy link
Contributor

sebkopf commented Oct 29, 2019

raw data could be cast as double_with_units, the same way the vendor data table is.

pros:

  • convenient for interacting with the data, less cluttered data access, can manage units and scaling independently of column names
  • current vs. voltage measurements would probably be fine thanks to the v44 and i44 prefixes

cons:

  • unclear how to reconcile raw data between different vendor data types if the units don't match (e.g. if have v44 in mV for one and v44 in V for another) - forced scaling first before aggregation?
  • several other processing pipelines already use the implicit unit columns from the raw data and would require fixing by calling an iso_make_units_implicit(prefix = ".", suffix = "") to continue working as used

please chime in if you feel strongly about this possibility

sebkopf referenced this issue Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant