-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: Set reply sorting to 'oldest' #1035
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for the quick patch! Left a few inline comments, mainly regarding the usage of comments.id
for sorting which I'd prefer you switch to comments.created
for consistency.
Thank you for addressing the feedback. Please squash your commits and give the resulting commit a more descriptive title/body, such as You also checked in an updated |
Fixed up as requested |
@ix5 do you plan to merge and release this? Thanks 🙏🏻 |
Checklist
CHANGES.rst
because this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
Quick SQL patch to fix #1026
Why is this necessary?
Current reply sorting leads to confusion. See linked issue for details.
NOTE: I tested this briefly and it seems to be working (and of course unit tests pass) but I wasn't sure if the sorting option was actually going through. Hard to tell on the demo page. Will probably test tmrw over curl.