Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If deployment has dash (-), the env will be the last word of the deployment name, not default #133

Open
wenxian opened this issue Aug 8, 2020 · 1 comment
Labels

Comments

@wenxian
Copy link

wenxian commented Aug 8, 2020

Describe the bug
If there is "-" in the deployment name, then the env will not be default but lastword

Steps To Reproduce

apiVersion: apps/v1
kind: Deployment
metadata:
  name: webapp-lastword
  namespace: sample
  labels:
    identity: webapp-identity
spec:
  replicas: 1
  selector:
    matchLabels:
      app: webapp-lastword
  template:
    metadata:
      annotations:
        sidecar.istio.io/inject: "true"
      labels:
        app: webapp-lastword
        identity: webapp-identity
    spec:
      containers:
      - command:
        - /bin/sleep
        - 3650d
        image: pstauffer/curl
        imagePullPolicy: IfNotPresent
        name: webapp-lastword

Expected behavior
The ServiceEntry created is lastword.webapp-identity.global

@wenxian wenxian added the bug Something isn't working label Aug 8, 2020
@aattuluri
Copy link
Contributor

@wenxian Is there a spec that states deployment name ends with env if it has a -?. I will change this to feature as it's not a bug.

@aattuluri aattuluri added enhancement New feature or request and removed bug Something isn't working labels Aug 21, 2020
@aattuluri aattuluri changed the title [BUG] If deployment has dash (-), the env will be the last world of the deployment name, not default If deployment has dash (-), the env will be the last world of the deployment name, not default Sep 2, 2020
@aattuluri aattuluri added this to the Nebulous Future milestone Sep 2, 2020
@benchi benchi changed the title If deployment has dash (-), the env will be the last world of the deployment name, not default If deployment has dash (-), the env will be the last word of the deployment name, not default Nov 23, 2020
itsLucario pushed a commit to itsLucario/admiral that referenced this issue Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants