Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Fail readiness probe until the caches are refreshed during boot up #244

Open
aattuluri opened this issue Jul 13, 2022 · 0 comments
Open

[FEATURE] Fail readiness probe until the caches are refreshed during boot up #244

aattuluri opened this issue Jul 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@aattuluri
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, admiral syncs all the k8s resources using controllers for different clusters. This takes time depending on the size of the clusters etc. During this time no updates are made to the resources. As a result there is a time window when a subsequent admiral version is deployed when no updates are made to the endpoints if resources like GTPs are edited during this time.

Describe the solution you'd like
Currently admiral has readiness probe, if we can fail the readiness probe until after the caches are refreshed then that would result in previous version of admiral still running until this instance comes up.
@aattuluri aattuluri added the enhancement New feature or request label Jul 13, 2022
kpharasi pushed a commit that referenced this issue Dec 19, 2024
router filter reconcile (#244)
7018662 
* handling tc overriding scenario and improving log formatting (#234)

* handling tc overriding scenario and improving log formatting

* fixing log formatter to print in json format

* traffic config cache by identity

* cache operations changes

* remove unused assignment

* log and moved queue push to new function

* log changes

* chore

* router reconcile changes & fixes

* fix dup imports

* use common method to check isDisabled

* fix: add assetalias to config

* add envoyfilter version as suffix

* read ignore clusters list from config file

* wait cache warmup and ignore api  gw clusters

* comon ispresent func

* fix unit test cases

* update annotations

* skip updating VirtualService for GW clusters

* update unit test and fixes

Co-authored-by: rgosavi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aattuluri