Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify FilterChain matcher and TriggerRule for API simplification #172

Open
Shikugawa opened this issue Oct 14, 2021 · 0 comments
Open

Unify FilterChain matcher and TriggerRule for API simplification #172

Shikugawa opened this issue Oct 14, 2021 · 0 comments

Comments

@Shikugawa
Copy link
Collaborator

TriggerRule and FilterChain matcher have overlapping functionality; TriggerRule currently uses only path attributes to determine whether to match or not. However, this can be achieved by specifying :path in the matcher's header. This issue is also related to #171 , if NotMatch is in the matcher, then the current TriggerRule can be completely eliminated to achieve the same functionality.

Currently, what we want to achieve with TriggerRule and Matcher is

  1. In the filter chain, if an attribute in the request header is matched, authentication is required.
  2. in the filter chain, if an attribute in the request header is not matched, do not require authentication
  3. In all filter chains, if neither match nor not-match an attribute in the request header, require default behavior (current implementation does not require authentication)

I think this will be All of these features should be available in Match, and we can eliminate the TriggerRule. This will also contribute to the simplification of the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant