Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cw version command #14

Open
mt-inside opened this issue Oct 22, 2018 · 3 comments
Open

cw version command #14

mt-inside opened this issue Oct 22, 2018 · 3 comments
Milestone

Comments

@mt-inside
Copy link
Contributor

Cute versions for users
Makes packaging and PR easier for us
should include git SHA for debugging

@ZackButcher
Copy link
Contributor

ZackButcher commented Oct 22, 2018

FYI Istio has a pkg/version which defines a struct for version and printing for it. It also has some scripts to populate the values at build time:

Probably not worth copying over the entire version package, but this should give you what you need to build something similar (where the info can be extracted at build time and included into the binary via linker flags).

@mt-inside
Copy link
Contributor Author

Ah thanks! I found an example using "github.com/christopherhein/go-version" so went for that. I'll send the PR your way.

@mt-inside mt-inside added this to the v0.2 milestone Oct 23, 2018
@mt-inside
Copy link
Contributor Author

Fixed by #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants