Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic auth filter to consume base64 encoded password #11

Open
bianpengyuan opened this issue Nov 3, 2020 · 5 comments
Open

Update basic auth filter to consume base64 encoded password #11

bianpengyuan opened this issue Nov 3, 2020 · 5 comments
Assignees

Comments

@bianpengyuan
Copy link
Collaborator

Currently basic auth filter only consumes plain text username:passwd. This is to track the work to make it read base64 encoded username:passwd instead.

@bianpengyuan bianpengyuan self-assigned this Nov 3, 2020
@mboveri
Copy link

mboveri commented Mar 24, 2021

Would this also add functionality to allow the basic auth filter to be able to consume from a Kubernetes secret or environment variable generated by a Kubernetes secret?

@bianpengyuan
Copy link
Collaborator Author

Yeah it depends on this: proxy-wasm/proxy-wasm-cpp-host#127

@bianpengyuan
Copy link
Collaborator Author

And envoy just added support for Wasm env variable read: envoyproxy/envoy#14958 I can add some support based on that.

@mboveri
Copy link

mboveri commented Mar 24, 2021

That would be great!

@johnzheng1975
Copy link

And envoy just added support for Wasm env variable read: envoyproxy/envoy#14958 I can add some support based on that.

@bianpengyuan , had istio supported this -- wasm can read env variable from istio-proxy now? Can you provide some example. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants