Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm-oidc-plugin #93

Open
antonengelhardt opened this issue Feb 12, 2024 · 6 comments · May be fixed by #95
Open

Add wasm-oidc-plugin #93

antonengelhardt opened this issue Feb 12, 2024 · 6 comments · May be fixed by #95

Comments

@antonengelhardt
Copy link

Hey there,

i figured it might be useful to include https://github.com/antonengelhardt/wasm-oidc-plugin/ inside this repo. Or are only Wasm Extension written in C++ featured?

Cheers

@kyessenov
Copy link
Collaborator

No, it's any language, as long as it can be built and tested in CI.

@antonengelhardt
Copy link
Author

@kyessenov Ok, thanks.

Should i open a PR? And how do you want it to be integrated?

@kyessenov
Copy link
Collaborator

Yes, you can open a PR. You might need to add a CI step for rust filters specifically, since the base probably doesn't have rust already.

@antonengelhardt
Copy link
Author

@kyessenov Ok. Does it make sense to add it as a submodule? I have not worked with that before but maybe this makes updating it easier?

@kyessenov
Copy link
Collaborator

It's easier with a copy I think. If you just want a mention on the docs there, we're happy to link to your repo.

@antonengelhardt
Copy link
Author

What do you think? #95

@antonengelhardt antonengelhardt linked a pull request Feb 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants