Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick missed #1598

Closed
geeknoid opened this issue Aug 5, 2019 · 7 comments
Closed

Cherry pick missed #1598

geeknoid opened this issue Aug 5, 2019 · 7 comments
Assignees
@fejta

Comments

@geeknoid
Copy link
Contributor

geeknoid commented Aug 5, 2019 •
edited
Loading

This PR wanted to be cherry picked to master, yet it didn't happen:

istio/istio.io#4753

Other PRs filed within minutes in the same repo did get automatically cherry picked, so the cherry picker is generally working. The one difference is that this PR was trying to cherry pick from release-1.2 to master, while the others are going from master to release-1.2.
@fejta
Copy link
Contributor

fejta commented Aug 5, 2019

/unassign @fejta @cjwagner
/assign @geeknoid

Please confirm that the webhook was delivered to the external plugin, which we do not have access to

@istio-testing istio-testing assigned geeknoid and unassigned fejta and cjwagner Aug 5, 2019
@geeknoid
Copy link
Contributor Author

geeknoid commented Aug 5, 2019

I did a "/cherrypick master", which triggered the cherry pick to happen.

@geeknoid
Copy link
Contributor Author

geeknoid commented Aug 5, 2019

The logs for the cherrypicker workload show 3 entries @ 12:18 today, related to the PR in question. I can't divine anything from these logs.

@geeknoid
Copy link
Contributor Author

geeknoid commented Aug 5, 2019

As shown in the screen shot, GitHub thinks it delivered all the necessary events successfully.

Screen Shot 2019-08-05 at 14 18 58

@fejta
Copy link
Contributor

fejta commented Aug 5, 2019

/unassign @geeknoid
/assign

@istio-testing istio-testing assigned fejta and unassigned geeknoid Aug 5, 2019
@istio-policy-bot istio-policy-bot added the lifecycle/needs-triage Indicates a new PR or issue needs to be triaged label Oct 30, 2019
@clarketm
Copy link
Member

clarketm commented Nov 26, 2019 •
edited
Loading

Were we ever able to identify the cause of the missed cherrypick or has there been any reoccurrence of this issue since?

😞 The logs are no longer retained for the affected time range of the original report.

@clarketm clarketm mentioned this issue Jan 28, 2020
Open
@clarketm
Copy link
Member

clarketm commented Mar 7, 2020

closing as duplicate of: #2309

@clarketm clarketm closed this as completed Mar 7, 2020
@istio-policy-bot istio-policy-bot removed lifecycle/needs-triage Indicates a new PR or issue needs to be triaged labels Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fejta fejta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fejta @cjwagner @clarketm @geeknoid @istio-policy-bot