Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue after deleting filter #50

Open
raszpi opened this issue Sep 17, 2014 · 1 comment
Open

issue after deleting filter #50

raszpi opened this issue Sep 17, 2014 · 1 comment

Comments

@raszpi
Copy link

raszpi commented Sep 17, 2014

hi,

after filtering and clicking on the show all button the selected value(s) won't move to the other column. after that it works fine.

awesome plugin by the way, keep up the good work :)

@heidilux
Copy link

heidilux commented Dec 5, 2019

Ran into the same issue (it's even reproducible on the demo page).

Seems like clicking the Show All button, while appearing to clear the filter, was still leaving the filtered set of options cached, so that the next time you clicked move (selected), it was only attempting to move whatever would have been visible in the previously filtered set.

Not sure if it's the best way to fix, but I resolved the issue by adding another call to the filter() method in the filterClear1 and filterClear2 event bindings.

E.g.

        dualListbox.elements.filterClear1.on('click', function() {
            dualListbox.setNonSelectedFilter('', true);
            filter(dualListbox,1);
        });

        dualListbox.elements.filterClear2.on('click', function() {
            dualListbox.setSelectedFilter('', true);
            filter(dualListbox,2);
        });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants