Does not play well with sandboxed-module

[domenic]

sandboxed-module is very useful for testing, but when my tests include a module via sandboxedModule.require, that module never gets code-covered.

If I manually include that module via require as well, then the module shows up as if no code inside it was ever run.

I can work to produce a minimal test case here if that would be helpful.

[itay]

@domenic a minimal test case would be useful. The problem is that Cover works by hooking into require, and sandboxed-module works by kind of replacing require. However, I can see if we can make them work together.

[domenic]

Here ya go. Should have just included it in the bug report.

// sut.js
var stubMe = require("stubMe");

module.exports = function () {
    if (true) {
        return 5;
    }
    return 6;
};

// test.js
var sandboxedModule = require("sandboxed-module");
var sut = sandboxedModule.require("./sut", {
    requires: { stubMe: { } }
});

// If i leave this as commented out, `sut` never even shows up in the coverage report.
// If I uncomment this, everything in `sut` shows up as uncovered.
//require("./sut");

sut();

I can definitely see where the two would interact poorly, but making them work together would be a big payoff, even if there's explicit integration (e.g. require("node-cover").useSandboxedModule(require("sandboxed-module"))).

[itay]

@domenic thank you! I'll definitely take a look. If needed, I'll talk to @felixge about it :)