Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full outer join support #808

Open
ilongin opened this issue Jan 10, 2025 · 2 comments
Open

Add full outer join support #808

ilongin opened this issue Jan 10, 2025 · 2 comments
Assignees

Comments

@ilongin
Copy link
Contributor

ilongin commented Jan 10, 2025

Our current API in both DataChain.merge() and internal DatasetQuery.join() support only inner and left outer join by setting inner flag to True or False.

We should add ability to do full outer join, as it's needed in some use cases like when comparing two chains.

Note that SQLite doesn't support full outer join out of the box, in earlier versions which we still support, so we will need to do some workaround with union all and two left joins.

@ilongin ilongin self-assigned this Jan 10, 2025
@dmpetrov
Copy link
Member

@ilongin is this somehow related to #721?

@ilongin
Copy link
Contributor Author

ilongin commented Jan 11, 2025

@ilongin is this somehow related to #721?

@dmpetrov yes it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants