Don't have a parameter within the function that is automatically overridden

[joeytalbot]

Currently, lines 57-65 of accessibility.R control the type parameter of get_jts_data()

if(grepl(pattern = "jts040", csv_filename)) {
      type = "la"
    }
    if(grepl(pattern = "jts050", csv_filename)) {
      type = "lsoa"
    }
    if(grepl(pattern = "to be confirmed!", csv_filename)) {
      type = "lpa"
    }

This means for example that even if you specify that you want to see LSOA data, you will see LA data if you pick a table that contains LA data. This is counterintuitive.

res = jts::get_jts_data(table = "jts0401", output_format = "sf", type = "lsoa")
#> Joining, by = "LA_Code"
plot(res)
#> Warning: plotting the first 9 out of 94 attributes; use max.plot = 94 to plot
#> all

^{Created on 2021-01-04 by the reprex package (v0.3.0)}

[Robinlovelace]

Well spotted, important issue to fix!