Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect triple-DH implementation #13

Open
digal opened this issue Sep 24, 2018 · 1 comment
Open

Incorrect triple-DH implementation #13

digal opened this issue Sep 24, 2018 · 1 comment
Assignees

Comments

@digal
Copy link

digal commented Sep 24, 2018

crypto_kdf_derive_from_key(subkey, keyLength, salt, infoLabel, secret.bytes);

crypto_kdf_derive_from_key takes const unsigned char key[crypto_kdf_KEYBYTES] as a last argument, where crypto_kdf_KEYBYTES = 32. So this call only uses first 32 bytes from secret (which is 96 or 128 bytes long, when called from - [IRTripleDHService sharedKeyFromReceiverIdentityKey:receiverSignedPreKey:receiverEphemeralKey:]), turning this code into a single DH implementation

@ivRodriguezCA ivRodriguezCA self-assigned this May 18, 2019
@ivRodriguezCA
Copy link
Owner

I completely abandoned this project.

Thank you so much for opening this issue 🙏🏼 I'll dedicate some time to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants