Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to modify approved request #57

Open
ivgraai opened this issue Jun 9, 2020 · 6 comments
Open

Allow to modify approved request #57

ivgraai opened this issue Jun 9, 2020 · 6 comments
Assignees
@yunusfirat
Labels
good first issue Good for newcomers story-point: 2 This rates the relative effort of work
Milestone
Sprint 8

Comments

@ivgraai
Copy link
Owner

ivgraai commented Jun 9, 2020

The API does support this!
@ivgraai ivgraai added the good first issue Good for newcomers label Jun 9, 2020
@ivgraai ivgraai added this to the Sprint 6 milestone Jun 11, 2020
@ivgraai ivgraai added the story-point: 5 This rates the relative effort of work label Jun 19, 2020
@ivgraai ivgraai added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 3, 2020
@ivgraai ivgraai removed the story-point: 5 This rates the relative effort of work label Jul 14, 2020
@ivgraai ivgraai removed this from the Sprint 6 milestone Jul 14, 2020
@ivgraai ivgraai added the queueing Waiting for setting up all the issue's attributes label Jul 14, 2020
@ivgraai ivgraai added this to the Sprint 7 milestone Jul 14, 2020
@ivgraai ivgraai added story-point: 3 This rates the relative effort of work and removed queueing Waiting for setting up all the issue's attributes labels Jul 14, 2020
@ivgraai ivgraai modified the milestones: Sprint 7, Sprint 8 Jul 31, 2020
@ivgraai
Copy link
Owner Author

ivgraai commented Aug 2, 2020

@agrim19
It could also be an introductory task for the new ones ^

@agrim19
Copy link
Contributor

agrim19 commented Aug 2, 2020

@agrim19
It could also be an introductory task for the new ones ^

Meaning? Should I try it out?

@ivgraai
Copy link
Owner Author

ivgraai commented Aug 2, 2020

I mean it is a good entry issue again. 🙂

@agrim19
Copy link
Contributor

agrim19 commented Aug 2, 2020

Oh right! Great!

@yunusfirat
Copy link
Contributor

I am the new one and I am interested! thank you.

@ivgraai
Copy link
Owner Author

ivgraai commented Aug 19, 2020 •
edited
Loading

@yunusfirat

Mainly you have to amend the ApprovalScreen.tsx file. At first you need to render buttons for other requests which are not approved. After you should implement the action to approve another request instead of the current one. We continue to use endpoint HttpClient::approveRequest because it is an update operation...

@ivgraai ivgraai added story-point: 2 This rates the relative effort of work and removed story-point: 3 This rates the relative effort of work labels Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunusfirat yunusfirat

Labels
good first issue Good for newcomers story-point: 2 This rates the relative effort of work
Projects
None yet
Milestone
Sprint 8
Development

No branches or pull requests
3 participants
@ivgraai @yunusfirat @agrim19