Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: change overflow-x, display of table element #463

Closed
wants to merge 1 commit into from
Closed

Fix: change overflow-x, display of table element #463

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 25, 2022

PR type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other... Please describe:

PR checklist

Please check if your PR fulfills the following requirements:

  • I have read the CONTRIBUTING.md doc
  • The Git workflow follows our guidelines: CONTRIBUTING.md#git
  • I have added necessary documentation (if appropriate)

What is the current behavior?

Issue number: #172

When the viewport reached a width of approximately 485px or less, the table element would clip the right-most table column with no ability for the user to scroll.

What is the new behavior?

When the table element reaches 485px or less, the table will extend past the viewport with the ability for the user to scroll.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Resolves #172

@ghost ghost changed the title fix: change overflow-x, display to block of table element Fix: change overflow-x, display of table element Nov 25, 2022
@jurajhilje jurajhilje self-assigned this Nov 26, 2022
@jurajhilje
Copy link
Member

jurajhilje commented Nov 26, 2022

@githubdev592 Thanks for the PR!

@gorkapernas It's deployed to staging for review. Let me know if resolves #172 and I'll merge it.

@ghost ghost closed this by deleting the head repository Nov 27, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise tables for small screens in the Guides section
1 participant