Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hugo and nodeJS versions #770

Closed
nathanrod opened this issue Apr 25, 2024 · 4 comments
Closed

Update Hugo and nodeJS versions #770

nathanrod opened this issue Apr 25, 2024 · 4 comments

Comments

@nathanrod
Copy link
Member

Currently we are using outdated Hugo and NodeJS versions, to support future features it is required to update them.

@nathanrod
Copy link
Member Author

nathanrod commented Apr 25, 2024

Related to #745
Deployed to staging.
Since Nodejs was updated, the clientarea has to be also reviewed.

@gorkapernas
Copy link
Member

gorkapernas commented Apr 26, 2024

Verified on staging, tested the website and client area, and nearly everything looks good, but an issue I found in the 'Apps' section.
It's probably not related to the HUGO updated, but there is a formatting issue in these two pages:
/apps-linux/
/apps-macos/

The commands in the instructions are not displayed properly, also there is a new section with instructions for the Signature Verification which is not in production (this section is in both macOS app and Linux app pages).

@gorkapernas gorkapernas assigned nathanrod and unassigned gorkapernas Apr 26, 2024
@nathanrod
Copy link
Member Author

nathanrod commented Apr 26, 2024

  • Fixed code highlight style

Regarding the apps-macos page, it is not part of the PR, on staging is just different. Not sure if it is a change that will be merged to prod in the future or not.

@nathanrod nathanrod assigned gorkapernas and unassigned nathanrod Apr 26, 2024
@gorkapernas
Copy link
Member

Verified fixed the issue with the code style, no more issues found in the website or client area.
This should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants