ILogger support #82
ILogger support #82
Conversation
Retain only .Net Standard 2.0 and 2.1 support. Bump version to indicate that its a major change.
Added support to use iLogger instead of writing log using console.Write. Updated example
Reflect support for only .Net standard 2.0 and 2.1
Updated to build/test for only .Net standard 2.0 and 2.1
Fix test case.
|
#76 - related to this question. |
Updated release notes for 3.1.0
| @@ -6,7 +6,7 @@ | |||
| <Authors>Jakub Maly;Stef Heyenrath;NTTAKR</Authors> | |||
| <Copyright>Copyright Jakub Maly & Stef Heyenrath © 2018-2022</Copyright> | |||
| <Company>Jakub Maly</Company> | |||
| <TargetFrameworks>net20;net35;net40;net45;net452;netstandard1.3;netstandard2.0;netstandard2.1</TargetFrameworks> | |||
There was a problem hiding this comment.
Please bring these older frameworks back.
There was a problem hiding this comment.
None of these older frameworks are supported. If someone needs to use this library with older frameworks, they can continue using the older version 3.0.x. Since we are using Microsoft.Extensions.Logging.Abstractions, this will force us to support 4.6.1 and above only. That was the reason to retain only .netstandard 2.0 and 2.1 and bump the version to 3.1.x.
There was a problem hiding this comment.
@askids
As general remark for NuGet packages, you don't know who is using this library which what framework, so even if frameworks are old, you cannot just remove these.
To solve this, you can make an own interface ILogger + ILogger<T> which mimics the Microsoft.Extensions.Logging.Abstractions for the older frameworks.
With this solution, you can use Microsoft.Extensions.Logging.Abstractions for .netstandard 2.0 and higher, and just use the custom ILogger for the older versions.
And a default implementation for a ConsoleLogger is required to keep the behavior and usage the same without having to use a new constructor.
There was a problem hiding this comment.
As general remark for NuGet packages, you don't know who is using this library which what framework, so even if frameworks are old, you cannot just remove these.
I get that. But I don't see this as a version that is continuing the support for old consumers or adding feature to it. This version is meant to be for those people who are upgrading/transitioning to the new model. Adding support for namesake for the old version is not going to help any existing consumers solve any new problem. Why would they even want to upgrade to this version which is not adding any new features for them or fixing any issues? If you want, we can bump the version from 3.1 to 4.0 to show that its a breaking change and update the documentation accordingly.
Remove Microsoft.Extensions.Logging dependency.
This reverts commit 92e08cf.
|
Add default Console Logger
Replace console.Write logging with ILogger using Microsoft logging extensions.